Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better gas handling for submit_reveal_aux #1879

Closed
grarco opened this issue Sep 8, 2023 · 1 comment · Fixed by #3720
Closed

Better gas handling for submit_reveal_aux #1879

grarco opened this issue Sep 8, 2023 · 1 comment · Fixed by #3720
Assignees
Labels
client gas post-mainnet Don't worry about this yet.

Comments

@grarco
Copy link
Collaborator

grarco commented Sep 8, 2023

At the moment, the client automatically detect whether the submission of a reveal_pk transaction is needed before submitting the intended transaction. The auxiliary reveal_pk transaction requires a gas limit and a gas payment and we are currently setting everything to the same values used for the intended transaction. This is not quite correct because:

  • The gas limit might be insufficient for the reveal pk transaction
  • The gas limit could be higher than the minimum required to reveal a public key leading to the gas payer spending too much on fees

We should manage the gas aspect of this ancillary tx better.

We can instead assume that the gas-price can be kept the same for both transactions as that define the priority that the signer is willing to give to the transaction which must be kept constant among the two to be meaningful.

@cwgoes cwgoes added the post-mainnet Don't worry about this yet. label Oct 26, 2023
@grarco
Copy link
Collaborator Author

grarco commented Aug 9, 2024

Actually this should now be extended: since we have batched transactions we should pack the reveal tx and the actual one in a single batch and handle them together. This will also solve the aforementioned gas issue since we'd need to set the gas limit for a single tx batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client gas post-mainnet Don't worry about this yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants