Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client validation for Bridge pool transfers #1800

Closed
Tracked by #2023
sug0 opened this issue Aug 9, 2023 · 0 comments · Fixed by #1957
Closed
Tracked by #2023

Add client validation for Bridge pool transfers #1800

sug0 opened this issue Aug 9, 2023 · 0 comments · Fixed by #1957
Labels
client ethereum-bridge good first issue Good for newcomers has-a-pr The issue has been solved by a PR that has yet to be merged prio:medium UX

Comments

@sug0
Copy link
Collaborator

sug0 commented Aug 9, 2023

Related to #1704

When adding a transfer to the Bridge pool, the client should perform some validations if --force is unset. For instance, it should be checked if gas fees are not being paid in wrapped NAM or NUTs, if the user has enough balance to pay the tx gas fees + the Bridge pool gas fees + the escrow, if the token cap of wrapped NAM won't be exceeded, etc.

@sug0 sug0 changed the title Add cilent validation for Bridge pool transfers Add client validation for Bridge pool transfers Aug 9, 2023
@sug0 sug0 added prio:medium good first issue Good for newcomers labels Aug 9, 2023
@sug0 sug0 added the has-a-pr The issue has been solved by a PR that has yet to be merged label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client ethereum-bridge good first issue Good for newcomers has-a-pr The issue has been solved by a PR that has yet to be merged prio:medium UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant