-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapper tx replay protection #178
Comments
The replay protection should probably be implemented in the protocol as it doesn't need to involve any VP. The counter field should then be added to the wrapper tx. For a tx to be valid, it should match the current value of the counter stored for the source implicit account in the ledger. To submit multiple txs from the same account at once, we should allow to explicitly set the |
with anoma/anoma#676, it should be possible to auto-increment the counter so the user never has to specify it explicitly |
So after some discussion, we came to the following idea:
|
Closed in favor of #1009 |
As noted in https://github.com/anoma/anoma/blob/625bab46c32da6aeb35418869974bfb1ac98cd3e/docs/src/specs/ledger.md: "DKG transactions will include replay protection (this is because we can simply check a counter against the source (i.e. gas payer) of the transaction before the transactions order is committed to by the DKG protocol, which could affect the expected counter order for sources with multiple queued transactions)".
We should add reply protection to the wrapper tx. This can simply be a counter in implicit accounts that is checked and incremented by the wrapper transactions.
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: