Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid tx hash from storage #1568

Closed
grarco opened this issue Jun 14, 2023 · 0 comments · Fixed by #1905
Closed

Remove invalid tx hash from storage #1568

grarco opened this issue Jun 14, 2023 · 0 comments · Fixed by #1905
Assignees
Labels
enhancement New feature or request ledger

Comments

@grarco
Copy link
Collaborator

grarco commented Jun 14, 2023

Currently, for replay protection, we remove the hash of an inner transaction from storage (i.e. allow replay) when the tx goes out of gas or if the transaction is Decrypted but was rejected by process_proposal. We should do the same in more cases:

  • if the inner tx turns out to be Undecryptable
  • if the signature on the inner tx is invalid (needs support on the WASM side)

Also add unit tests for these cases

@grarco grarco added enhancement New feature or request ledger labels Jun 14, 2023
@grarco grarco self-assigned this Jun 14, 2023
@grarco grarco changed the title Remove invalid commitment tx hash from storage Remove invalid tx hash from storage Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ledger
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant