Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot compare IbcAmounts with Namada Amounts #1451

Closed
Tracked by #2021
batconjurer opened this issue May 22, 2023 · 2 comments
Closed
Tracked by #2021

Cannot compare IbcAmounts with Namada Amounts #1451

batconjurer opened this issue May 22, 2023 · 2 comments
Assignees
@yito88

Comments

@batconjurer
Copy link
Member

The IbcAmount type in ibc-rs keeps it's int type private and has a very limited API. We cannot compare IbcAmounts with namada Amounts as a result (for example bounds checking).
@yito88
Copy link
Member

yito88 commented May 24, 2023

I had the same concern and asked about it.
We can get the U256 from IbcAmount with the derive.

@cwgoes cwgoes mentioned this issue Oct 20, 2023
Closed
23 tasks
@yito88
Copy link
Member

yito88 commented Nov 11, 2023

Fixed in #1784

@yito88 yito88 closed this as completed Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yito88 yito88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yito88 @batconjurer