Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error handling in init_chain #126

Closed
tzemanovic opened this issue Jun 1, 2022 · 4 comments
Closed

improve error handling in init_chain #126

tzemanovic opened this issue Jun 1, 2022 · 4 comments

Comments

@tzemanovic
Copy link
Member

there are some unwraps in the init_chain (and possibly other shell's methods?) - ideally these should be propagate up to the method's Result

@tzemanovic
Copy link
Member Author

see anoma/anoma#1099 (comment) which improved the wasm_loader error handling

@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@cwgoes
Copy link
Collaborator

cwgoes commented Jan 12, 2023

@tzemanovic is this still relevant?

@tzemanovic
Copy link
Member Author

@tzemanovic is this still relevant?

I'd say so, but it's probably not a high priority for now

@tzemanovic
Copy link
Member Author

On a second thought, it's better to crash on any errors than to return the errors back to tendermint as it's clearer to see what happened. With the new genesis #2088 and #2130, we should be able to prevent invalid chain configurations. Any other issues are not recoverable

@tzemanovic tzemanovic closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2023
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

2 participants