Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end test asserting protocol transactions are rejected when submitted via Tendermint #113

Closed
james-chf opened this issue May 16, 2022 · 2 comments
Labels

Comments

@james-chf
Copy link
Contributor

anomac which we use for submitting transactions in our e2e tests is not able to send protocol transactions and probably it doesn't make sense for it to have that functionality, since in practice those should always be broadcast by validators running anoman. It would be useful to have a way to submit protocol transactions in another way for testing.

We can use TendermintWebsocketClient (although it is being deprecated) to build a protocol transaction in memory and submit it to the Tendermint RPC endpoint. We should already have the e2e test node validators' protocol keys available to us in the e2e tests.

This issue is motivated by anoma/anoma#1094 which needs this sort of functionality for testing.

@james-chf james-chf self-assigned this May 16, 2022
@james-chf james-chf changed the title Be able to submit protocol transactions in our end-to-end test Be able to submit protocol transactions in our end-to-end tests May 16, 2022
@james-chf
Copy link
Contributor Author

I put some functionality in https://github.com/anoma/devtool for submitting protocol transactions manually to a chain. End-to-end tests for submitting a protocol transaction to Tendermint are working for ABCI in anoma/anoma#1094. Submitting protocol transactions this way to modify the Ethereum bridge may not be applicable anymore in which case the generic functionality for submitting a protocol transaction within an e2e test can be factored out of that PR into a new PR if needed. There is a new Tendermint client coming in anoma/anoma#1088 that should be used in such tests instead of TendermintWebsocketClient

@james-chf james-chf changed the title Be able to submit protocol transactions in our end-to-end tests End-to-end tests asserting protocol transactions are rejected when submitted via Tendermint Jun 24, 2022
@james-chf james-chf changed the title End-to-end tests asserting protocol transactions are rejected when submitted via Tendermint Add end-to-end test asserting protocol transactions are rejected when submitted via Tendermint Jul 5, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@james-chf james-chf removed their assignment Sep 9, 2022
@james-chf james-chf added the wontfix This will not be worked on label Sep 23, 2022
@james-chf
Copy link
Contributor Author

No longer valid. We will accept certain protocol transactions via Tendermint, at least for the design of the Ethereum bridge that we will be using with Tendermint v0.37 (which doesn't have vote extensions).

Repository owner moved this from Todo to Tested in Devnet in Namada-Old Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

1 participant