Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent defaults for PoS and Governance and Parameters #1033

Closed
Tracked by #2004
mariari opened this issue Jan 17, 2023 · 1 comment · Fixed by #2088
Closed
Tracked by #2004

Inconsistent defaults for PoS and Governance and Parameters #1033

mariari opened this issue Jan 17, 2023 · 1 comment · Fixed by #2088
Assignees

Comments

@mariari
Copy link
Member

mariari commented Jan 17, 2023

The default parameters for PosParams and GovParams disagrees with the default values set in dev.toml.

PoS parameters:

  • max_validator_slots in particular

https://github.com/anoma/namada/blob/main/proof_of_stake/src/parameters.rs#L47

https://github.com/anoma/namada/blob/main/genesis/dev.toml#L155

Governance parameters:

  • max_proposal_content_size in particular

https://github.com/anoma/namada/blob/main/core/src/ledger/governance/parameters.rs#L61

https://github.com/anoma/namada/blob/main/genesis/dev.toml#L190

@mariari mariari changed the title Inconsistent defaults for PoS Parameters Inconsistent defaults for PoS and Governance and Parameters Jan 17, 2023
@tzemanovic
Copy link
Member

sry, the dev.toml is outdated as it's not being used - we're re-working the genesis setup in #685 and dev.toml will be replaced. I don't think that the "dev" local net setup necessarily has to use the defaults, although it would probably be nicer if it did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants