From 7b253e96ce107a54e80e6b437b516c2af428c8f8 Mon Sep 17 00:00:00 2001
From: Gianmarco Fraccaroli <>
Date: Mon, 8 May 2023 11:38:42 +0200
Subject: [PATCH] tests: improve e2e tests

---
 .github/workflows/scripts/e2e.json |  2 +-
 tests/src/e2e/ledger_tests.rs      | 12 ++++++++++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/scripts/e2e.json b/.github/workflows/scripts/e2e.json
index a6900183dd0..c915752907f 100644
--- a/.github/workflows/scripts/e2e.json
+++ b/.github/workflows/scripts/e2e.json
@@ -11,7 +11,7 @@
     "e2e::ledger_tests::pos_bonds": 19,
     "e2e::ledger_tests::pos_init_validator": 15,
     "e2e::ledger_tests::proposal_offline": 15,
-    "e2e::ledger_tests::pgf_governance_proposal": 35,
+    "e2e::ledger_tests::pgf_stewards_governance_proposal": 35,
     "e2e::ledger_tests::eth_governance_proposal": 35,
     "e2e::ledger_tests::proposal_submission": 35,
     "e2e::ledger_tests::run_ledger": 5,
diff --git a/tests/src/e2e/ledger_tests.rs b/tests/src/e2e/ledger_tests.rs
index 3fb9642519a..6e5b2c6c295 100644
--- a/tests/src/e2e/ledger_tests.rs
+++ b/tests/src/e2e/ledger_tests.rs
@@ -2891,6 +2891,15 @@ fn proposal_submission() -> Result<()> {
     client.exp_regex(".*Min. proposal grace epochs: 9.*")?;
     client.assert_success();
 
+    // 14. Query parameters
+    let query_protocol_parameters =
+        vec!["query-protocol-parameters", "--node", &validator_one_rpc];
+
+    let mut client =
+        run!(test, Bin::Client, query_protocol_parameters, Some(30))?;
+    client.exp_regex(".*Min. proposal grace epochs: 9.*")?;
+    client.assert_success();
+
     Ok(())
 }
 
@@ -3123,7 +3132,6 @@ fn eth_governance_proposal() -> Result<()> {
 // Test submission and vote of a PGF proposal
 #[test]
 fn pgf_stewards_governance_proposal() -> Result<()> {
-    // FIXME:
     let test = setup::network(
         |genesis| {
             let parameters = ParametersConfig {
@@ -3186,7 +3194,7 @@ fn pgf_stewards_governance_proposal() -> Result<()> {
     };
 
     let valid_proposal_json_path =
-        prepare_proposal_data(&test, albert, vec![pgf_stewards]);
+        prepare_proposal_data(&test, albert.clone(), vec![pgf_stewards]);
     let validator_one_rpc = get_actor_rpc(&test, &Who::Validator(0));
 
     let submit_proposal_args = vec![