-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdk: add claim rewards #932
Merged
Merged
+433
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
sdk-claim-rewards
branch
from
July 16, 2024 02:07
798e4e8
to
5827ce9
Compare
emccorson
force-pushed
the
sdk-claim-rewards
branch
2 times, most recently
from
July 16, 2024 03:38
248669a
to
71427dc
Compare
Closed
emccorson
force-pushed
the
sdk-claim-rewards
branch
from
July 16, 2024 04:10
71427dc
to
e919505
Compare
emccorson
force-pushed
the
sdk-claim-rewards
branch
from
July 22, 2024 00:48
e919505
to
fd29ef4
Compare
emccorson
requested review from
jurevans,
mateuszjasiuk,
euharrison and
pedrorezende
and removed request for
jurevans
July 22, 2024 01:09
jurevans
reviewed
Jul 22, 2024
jurevans
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Just left a note about docs/README.md
, I think we can just remove those changes for now
emccorson
force-pushed
the
sdk-claim-rewards
branch
from
July 23, 2024 01:32
fd29ef4
to
675ea28
Compare
mateuszjasiuk
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! :)
- Show real dates/times for proposals instead of epochs - Show the time remaining for ongoing proposals
emccorson
force-pushed
the
sdk-claim-rewards
branch
from
July 24, 2024 00:26
675ea28
to
59d0ea9
Compare
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #679.
Added
Testing
namadac rewards
.window.sdk = sdk; window.BigNumber = BigNumber;
and then in the console something like: