Murisi/box impl build params #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/box-impl-build-params
branch
from
7b2316a to
f2b0cae
Compare
1 task
…perceded by the ExtendedKey trait. Removed BuildParams::auth_sig because signatures can be modified after the build using the MapAuth trait.
murisi
force-pushed
the
murisi/box-impl-build-params
branch
from
dacba7f to
2914e6f
Compare
tzemanovic
approved these changes
Oct 3, 2024
murisi
force-pushed
the
murisi/box-impl-build-params
branch
from
2914e6f to
65d3e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some changes to facilitate the signing of MASP
Transactions using the hardware wallet:BuildParamsfor boxes to enable consumers to dynamically switch betweenRngBuildParamsandStoredBuildParamsask,ak,nsk, andnkto allow consumers to force transaction construction in the presence of inconsistencies/incomplete information (like knownakbut unknownask)ExtendedSpendingKeywhich might not enforce certain relations to be used