Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(banque de france): add banque de france data #1486

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

rmonnier9
Copy link
Contributor

@rmonnier9 rmonnier9 commented Dec 24, 2024

  • Fonctionnalité

  • Détails :

    • Ajout des données de la banque de France
  • : Comment présenter les données détaillées du bilan ?

Closes #1481

Données "Valeurs calculées" :
image

image

@rmonnier9 rmonnier9 requested a review from XavierJp as a code owner December 24, 2024 14:06
@rmonnier9 rmonnier9 changed the title feat(banque de france): add banque de france data [WIP] feat(banque de france): add banque de france data Dec 24, 2024
@rmonnier9 rmonnier9 force-pushed the banque-de-france branch 3 times, most recently from ce453cd to 330953e Compare December 29, 2024 10:51
@rmonnier9 rmonnier9 changed the title [WIP] feat(banque de france): add banque de france data feat(banque de france): add banque de france data Dec 29, 2024
@rmonnier9 rmonnier9 force-pushed the banque-de-france branch 6 times, most recently from 6d4b1ac to 59731f6 Compare December 30, 2024 09:34
Copy link
Contributor

@XavierJp XavierJp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://entreprise.api.gouv.fr/catalogue/banque_de_france/bilans

Cette API concerne uniquement les entreprises réalisant un chiffre d’affaire supérieur à 750 000 euros et ayant a minima trois bilans
Même si la Banque de France connaît un ou deux bilans de l’entreprise, ces derniers ne seront pas transmis.

Maybe we should add a condition on company creation date > 3 year
The 750k condition is harder to get

I think we can merge this PR as a it is a good start. And then we should work to merge

  • open data finances
  • CA from DGFIP
  • Bilans from BdF as it actually is another set of "indicateurs financier"

This have me think we should maybe have a default for open data and another for agent, that return the data the agent is authorize to access

utils/helpers/formatting/formatting.ts Outdated Show resolved Hide resolved
utils/helpers/formatting/formatting.ts Outdated Show resolved Hide resolved
models/espace-agent/chiffre-affaires/index.ts Outdated Show resolved Hide resolved
models/espace-agent/bilans/index.ts Outdated Show resolved Hide resolved
components/finances-section/societe-bilans/index.tsx Outdated Show resolved Hide resolved
@rmonnier9 rmonnier9 force-pushed the banque-de-france branch 4 times, most recently from fcb7b66 to 2cf9e9b Compare January 10, 2025 09:51
Comment on lines +43 to +45
const isMoreThanThreeYearsOld =
new Date(uniteLegale.dateDebutActivite).getFullYear() + 3 <=
new Date().getFullYear();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierJp
I've added a 3 years old condition.

@rmonnier9 rmonnier9 merged commit cacdd77 into main Jan 13, 2025
8 checks passed
@rmonnier9 rmonnier9 deleted the banque-de-france branch January 13, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nouvelle donnée : Banque de France Bilans
2 participants