Debounce mathjax rendering to avoid stalling #3827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae
reviewed
Feb 18, 2025
ts/editable/Mathjax.svelte
Outdated
| @@ -25,13 +25,17 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html | |||
| import { pageTheme } from "$lib/sveltelib/theme"; | |||
|
|
|||
| import { convertMathjax, unescapeSomeEntities } from "./mathjax"; | |||
| import { ChangeTimer } from "../editor/change-timer"; | |||
There was a problem hiding this comment.
While not a problem at the moment as we have a single compilation unit, this is introducing a circular dependency. change-timer would be better moved to editable or something like sveltelib.
iamllama
force-pushed
the
mathjax-debounce
branch
from
010e642 to
f0fd95e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3803
Typing in the mathjax editor causes it to rerender, which can be slow when done per character, given a large enough expression
This pr proposes to debounce rendering to svg by 500ms to avoid stalls