-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop reporting storage access exceptions to acrarium #17470
fix: stop reporting storage access exceptions to acrarium #17470
Conversation
these no longer generate useful reports
David knows way more than me about storage issues, so he should have a firmer opinion than I. The fix here looks alright, but I'm not sure if this error occur in new play installations. Theoretically, it shouldn't, but I wouldn't be surprised if there is some kind of platform bug somewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem fine and if David is ok with silencing the exception report I'm also ok with silencing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a later date we should handle this lower down in the crash reporting mechanism. This only blocks the exception in launchCatchingTask
If it's been tested, let's get it in
Purpose / Description
these no longer generate useful reports
Fixes
/storage/emulated/0/AnkiDroid
#17373Approach
This stops reporting one specific error in coroutine handler and in startup
How Has This Been Tested?
Ran it manually and watched logcat, using the test-trigger-patch from linked issue
No more exception report
Learning (optional, can help others)
Our startup logic is a tangle!
Our coroutine error handling logic is a tangle!
Checklist
Please, go through these checks before submitting the PR.