fix(manage-space): crash if getPackageSizeInfo fails
#17413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a (knockoff?) API 25 phone, `getPackageSizeInfo` failed with ``` java.lang.NoSuchMethodException: getPackageSizeInfo [class java.lang.String, interface b.a] at java.lang.Class.getMethod(Class.java:1981) at java.lang.Class.getMethod(Class.java:1637) at com.ichi2.anki.ui.windows.managespace.FileUtilsKt.getUserDataAndCacheSizeUsingGetPackageSizeInfo(FileUtils.kt:115) ``` We fix this via: * handling the exception * documenting the exception Fixes 17387
david-allison
commented
Nov 10, 2024
| @@ -38,6 +38,7 @@ import kotlin.coroutines.resume | |||
| /** | |||
| * Get the size of user data and cache for the current package, in bytes. | |||
| * This should amount to the sum of User data and Cache in App info -> Storage and cache. | |||
| * @throws NoSuchMethodException occasionally on some phones < [Build.VERSION_CODES.O] (#17387) | |||
There was a problem hiding this comment.
I link the version code so this will be seen when we upgrade the minSdk
mikehardy
added
Review High Priority
lukstbit
added
Pending Merge
github-actions
bot
removed
Review High Priority
mikehardy
added
Cherry Picked to Stable Branch
and removed
Queued for Cherry Pick to Stable Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a (knockoff?) API 25 phone,
getPackageSizeInfofailed withFixes
Approach
How Has This Been Tested?
I modified the code to throw an exception
Checklist