Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Activity Not found exception #17396

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

criticalAY
Copy link
Contributor

@criticalAY criticalAY commented Nov 8, 2024

Purpose / Description

Fixes

Approach

Use try-catch and show snackbar to the user

How Has This Been Tested?

Local build, API35
image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a Timber.w. Implementer's choice

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 8, 2024
@criticalAY criticalAY force-pushed the fix-naf-exception branch 3 times, most recently from 339dcb4 to 0549ea1 Compare November 8, 2024 20:33
@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Queued for Cherry Pick to Stable Branch labels Nov 9, 2024
@criticalAY criticalAY removed Needs Author Reply Waiting for a reply from the original author Strings labels Nov 9, 2024
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think lukstbit items are all ticked off as well but re-pinging on that for agreement
Thanks for crushing a crash

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 9, 2024
@lukstbit lukstbit added this pull request to the merge queue Nov 9, 2024
Merged via the queue into ankidroid:main with commit dd0e890 Nov 9, 2024
9 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 9, 2024
@github-actions github-actions bot added this to the 2.20 Release milestone Nov 9, 2024
@mikehardy mikehardy modified the milestones: 2.20 Release, 2.19.2 release Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants