i18n sync workflow on ubuntu / bump javascript deps #15325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
our i18n infrastructure used to rely on some macOS-specific behavior, but now that it is all javascript I don't think the runner OS actually matters if it does not matter, then ubuntu is preferred as macos has limited concurrency on free accounts
they're all minors and/or patches so nothing special closes out all the dependabot issues for javascript deps at once
mikehardy
added
the
Pending Merge
|
this has nothing to do with java unit or instrumented tests, so merging now to enable an i18n sync to make sure it works |
github-actions
bot
removed
the
Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
our i18n infrastructure used to rely on some macOS-specific behavior,
but now that it is all javascript I don't think the runner OS actually
matters
if it does not matter, then ubuntu is preferred as macos has limited
concurrency on free accounts
How Has This Been Tested?
It isn't easy to test these, I plan on running a sync as soon as it merges to determine if it works or not, will rollback immediately if it fails of course