Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump org.robolectric:robolectric from 4.10.3 to 4.11 #14617

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2023

Bumps org.robolectric:robolectric from 4.10.3 to 4.11.

Release notes

Sourced from org.robolectric:robolectric's releases.

Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. If you need to continue testing on Android SDK levels 18 and below, continue to use Robolectric 4.10.3.

Note that running tests on SDK 34 requires JDK 17.

What's Changed

... (truncated)

Commits
  • ef09063 Bump version to 4.11.
  • a29c7a6 Fix zero-width text views for LEGACY graphics in Android U+
  • d068642 Add support for 2-arg Typeface constructor in legacy ShadowTypeface
  • 1341c57 Merge branch 'master' into robolectric-4.11.x
  • d75572b Downgrade guava to 31.1 and stop auto updates.
  • 8ce1732 Merge branch 'master' into robolectric-4.11.x
  • 6e4a3b4 Bump version to 4.12-SNAPSHOT.
  • 2f36230 Make integration_tests:jacoco-offline resilient to jacoco version changes
  • 3d992b9 Bump version to 4.11-beta-1.
  • 6eea5df Bump org.jacoco:org.jacoco.agent from 0.8.10 to 0.8.11
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.robolectric:robolectric](https://github.com/robolectric/robolectric) from 4.10.3 to 4.11.
- [Release notes](https://github.com/robolectric/robolectric/releases)
- [Commits](robolectric/robolectric@robolectric-4.10.3...robolectric-4.11)

---
updated-dependencies:
- dependency-name: org.robolectric:robolectric
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies used for automated dependency PRs label Oct 30, 2023
@mikehardy
Copy link
Member

@david-allison I suppose this could be / should be a squash-merge but then there may still be a quibble with the API target version. I could pull it out completely if so, but to be honest it was kind of a no-op since it was just the API module and there was no adjustment of anything necessary

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the commits doesn't compile (so it NEEDS to be at least somewhat squashed): could we cherry pick the sdk bump onto main and then squash this?

@mikehardy
Copy link
Member

I'll just peel the bump to a separate PR so I don't have to fiddle with main directly, I endeavour to never do that with my only personal exception being when I'm directly working with publishing workflows as I can't really test them otherwise or it is some sort of true emergency and this doesn't qualify for either

…downloads

this was only necessary before because there was an upstream bug in robolectric 4.10.3,
now that 4.11.0 is out, we can use robolectric SDK 33 and in fact move forwrd to 34

this implies that our SDK pre-downloads should be altered as well, these are the ones
downloaded now on clean runs
- one test disable: API longer responds correctly, but manual test was successful
- one test adjustement to reflect typo fix in robolectric APIs
@mikehardy mikehardy force-pushed the dependabot/gradle/dependency-updates/org.robolectric-robolectric-4.11 branch from 54988d1 to d21593f Compare October 30, 2023 16:59
@mikehardy mikehardy added the squash-merge The pull request currently requires maintainers to "Squash Merge" label Oct 30, 2023
@mikehardy
Copy link
Member

api targetSdk peeled to #14620

@mikehardy mikehardy merged commit ea07b1d into dependency-updates Oct 31, 2023
7 checks passed
@mikehardy mikehardy deleted the dependabot/gradle/dependency-updates/org.robolectric-robolectric-4.11 branch October 31, 2023 14:45
@github-actions github-actions bot added this to the 2.17 release milestone Oct 31, 2023
@github-actions github-actions bot removed the squash-merge The pull request currently requires maintainers to "Squash Merge" label Oct 31, 2023
mikehardy added a commit that referenced this pull request Oct 31, 2023
* build(deps): bump org.robolectric:robolectric from 4.10.3 to 4.11 (#14617)

* build(deps): bump org.robolectric:robolectric from 4.10.3 to 4.11

Bumps [org.robolectric:robolectric](https://github.com/robolectric/robolectric) from 4.10.3 to 4.11.
- [Release notes](https://github.com/robolectric/robolectric/releases)
- [Commits](robolectric/robolectric@robolectric-4.10.3...robolectric-4.11)

---
updated-dependencies:
- dependency-name: org.robolectric:robolectric
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): remove robolectric SDK pin so it auto-tracks, alter SDK downloads

this was only necessary before because there was an upstream bug in robolectric 4.10.3,
now that 4.11.0 is out, we can use robolectric SDK 33 and in fact move forwrd to 34

this implies that our SDK pre-downloads should be altered as well, these are the ones
downloaded now on clean runs

* test: adjust to match robolectric 4.11 needs

- one test disable: API longer responds correctly, but manual test was successful
- one test adjustement to reflect typo fix in robolectric APIs

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Hardy <[email protected]>

* build(deps): bump kotlin_version from 1.9.10 to 1.9.20

Bumps `kotlin_version` from 1.9.10 to 1.9.20.

Updates `org.jetbrains.kotlin.jvm` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin.android` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin.plugin.parcelize` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin.plugin.serialization` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin:kotlin-reflect` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin:kotlin-test` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin:kotlin-test-junit5` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin:kotlin-test-junit` from 1.9.10 to 1.9.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin.jvm
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin.android
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin.plugin.parcelize
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin.plugin.serialization
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin:kotlin-reflect
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin:kotlin-test
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin:kotlin-test-junit5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin:kotlin-test-junit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies used for automated dependency PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants