Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove chess notation support #14215

Closed
wants to merge 1 commit into from
Closed

chore: remove chess notation support #14215

wants to merge 1 commit into from

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Aug 9, 2023 •
edited
Loading

Purpose / Description

this completes 99799ca by removing a reference to the deleted chess.css

Removed in: 99799ca#diff-58bcd503b1404ef531943f5842219768f82d271f6ce8f0da93a7860e48aa9639

Fixes

Approach

Removes a missed reference

How Has This Been Tested?

Untested

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
chore: remove chess notation support
a63d7e9 
this completes 99799ca
by removing a reference to the deleted chess.css

Fixes Issue 14092
@BrayanDSO
Copy link
Member

BrayanDSO commented Aug 10, 2023 •
edited
Loading

I had noticed the same, but pushed at the new backend PR 0bce67d (#14171)

Maybe would be better to keep it there to avoid conflicts

@david-allison
Copy link
Member Author

I had noticed the same, but pushed at the new backend PR 0bce67d (#14171)

Maybe would be better to keep it there to avoid conflicts

Up to you. Happy to close this

@BrayanDSO
Copy link
Member

So, I'm going to close this to avoid more work there. Thanks, David

@BrayanDSO BrayanDSO closed this Aug 11, 2023
@david-allison david-allison deleted the remove-chess branch August 11, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "Chess notation support"
2 participants
@david-allison @BrayanDSO