Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Card Browser - Toggle Notes -> Changing deck in Note Editor only modifies one card #17415

Open
4 tasks done
Hyoogen-no-Kachi opened this issue Nov 10, 2024 · 10 comments
Open
4 tasks done
Assignees
Labels
2.18 2.19 Bug Card Browser Note Editor Addition, editing & note type changes Reproduced This bug has been reproduced by a maintainer

Comments

@Hyoogen-no-Kachi
Copy link

Hyoogen-no-Kachi commented Nov 10, 2024

Checked for duplicates?

  • This issue is not a duplicate

Does it also happen in the desktop version?

  • This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

  1. Create 2 decks, Test 1 and Test 2
  2. Create a cloze note e.g. {{c1::Hello}} {{c2::World}}! in the Test 1 deck
  3. Go to the Card Browser on AnkiDroid, click on the 3 dots, click on Options, and set Toggle Notes
  4. Search for Hello World! on the search bar.
  5. If you notice, when you click in the arrow and change Sort Field to Question, only one card will appear.
  6. ⚠️ Click on the note/card and change the deck from Test 1 to Test 2.
  7. Now, if you go back to the main screen or you go back to the Card Browser and set Toggle Cards again, you’ll see that only one card changed deck.

Expected behaviour

  1. I expected to change all cards of the notes of its original deck at once
  2. I expected that the decks name of the cards on the browser desktop would be the name I setted, and not (1) or (2)

Debug info

AnkiDroid Version = 2.18.4 (f867da96b8304edaebd0361326316bc7514f8cde)

Backend Version = 0.1.38-anki24.04.1 (24.04.1 ccd9ca1a8309b80bcb50ddc5d99c7ce63440bce9)

Android Version = 13 (SDK 33)

ProductFlavor = play

Manufacturer = samsung

Model = SM-A226BR

Hardware = mt6833

Webview User Agent = Mozilla/5.0 (Linux; Android 13; SM-A226BR Build/TP1A.220624.014; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/130.0.6723.86 Mobile Safari/537.36

ACRA UUID = d549ca88-5110-4f4d-9b75-1f1552dc6095

FSRS Enabled = true

Crash Reports Enabled = true

(Optional) Anything else you want to share?

Reported here https://forums.ankiweb.net/t/bug-report-notes-arent-in-the-deck-where-they-supposed-to-be/51355/6

In it there is more context

Research

  • I have checked the manual and the FAQ and could not find a solution to my issue
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
Copy link

welcome bot commented Nov 10, 2024

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

@david-allison

This comment has been minimized.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Nov 10, 2024
@Hyoogen-no-Kachi

This comment has been minimized.

@david-allison

This comment has been minimized.

@Hyoogen-no-Kachi

This comment has been minimized.

@david-allison david-allison added 2.18 2.19 and removed Needs Author Reply Waiting for a reply from the original author labels Nov 11, 2024
@david-allison

This comment has been minimized.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Nov 12, 2024
@Hyoogen-no-Kachi

This comment has been minimized.

@david-allison david-allison changed the title [BUG]: Toggle Notes + Change the deck of notes, and not only cards + deck name appear as (1) or (2) on desktop's browser when the note's deck is changed on AnkiDroid with Toggle Browser activated [BUG]: Card Browser - Toggle Notes -> Changing deck in Note Editor only modifies one card Nov 13, 2024
@david-allison david-allison added Note Editor Addition, editing & note type changes Reproduced This bug has been reproduced by a maintainer Card Browser and removed Needs Author Reply Waiting for a reply from the original author Needs Triage labels Nov 13, 2024
@david-allison
Copy link
Member

Ref:

try {
val cardId = getCardIdForNoteEditor()
openNoteEditorForCard(cardId)
} catch (e: Exception) {
Timber.w(e, "Error Opening Note Editor")
showSnackbar(
R.string.multimedia_editor_something_wrong,
Snackbar.LENGTH_LONG
)
}

The above must handle multiselect and NOTES mode.

For now it only handles multiselect.

The Note Editor may also want to be modified to handle an edit of a Note, rather than a Card

@david-allison david-allison added this to the 2.19.2 release milestone Nov 13, 2024
@SttApollo
Copy link

Can you assign this to me?

@david-allison
Copy link
Member

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.18 2.19 Bug Card Browser Note Editor Addition, editing & note type changes Reproduced This bug has been reproduced by a maintainer
Projects
None yet
Development

No branches or pull requests

4 participants