Skip to content

Commit

Permalink
build(deps): remote obsolete gradle home cache cleanup property
Browse files Browse the repository at this point in the history
- this was toggled on for 3 workflows, it is on by default not: removing
- this was *not* toggled on for unit tests because we have observed problems before,
  but now it is the default for everyone and I am assertively/hopefully assuming
  they have fixed the problems we have seen (or will do so shortly) so letting it
  become enabled with its new default setting

Note that if workflow runs start failing, this was the comment leading to upstream
information:

gradle-home-cache-cleanup is temporarily disabled to investigate cache pollution issues
Requested in: gradle/actions#167 (comment)
gradle-home-cache-cleanup: true
  • Loading branch information
mikehardy committed Sep 6, 2024
1 parent 25a1e98 commit 37bc8f2
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion .github/workflows/compare_apk_size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
timeout-minutes: 5
with:
cache-read-only: true
gradle-home-cache-cleanup: true

- name: Checkout PR
uses: actions/checkout@v4
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ jobs:
# Builds on other branches will only read from main branch cache writes
# Comment this and the with: above out for performance testing on a branch
cache-read-only: ${{ github.ref != 'refs/heads/main' }}
gradle-home-cache-cleanup: true

- name: Warm Gradle Cache
# This makes sure we fetch gradle network resources with a retry
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests_emulator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ jobs:
# Builds on other branches will only read from main branch cache writes
# Comment this and the with: above out for performance testing on a branch
cache-read-only: ${{ github.ref != 'refs/heads/main' }}
gradle-home-cache-cleanup: true

# This appears to be 'Cache Size: ~1230 MB (1290026823 B)' based on watching action logs
# Repo limit is 10GB; branch caches are independent; branches may read default branch cache.
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/tests_unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ jobs:
# Builds on other branches will only read from main branch cache writes
# Comment this and the with: above out for performance testing on a branch
cache-read-only: ${{ github.ref != 'refs/heads/main' }}
# gradle-home-cache-cleanup is temporarily disabled to investigate cache pollution issues
# Requested in: https://github.com/gradle/actions/issues/167#issuecomment-2052352341
# gradle-home-cache-cleanup: true

- name: Gradle Dependency Download
uses: nick-invision/retry@v3
Expand Down

0 comments on commit 37bc8f2

Please sign in to comment.