enhacement: allow the apkg packages to be shared with AnkiDroid

ankidroid · Mar 20, 2024 · 08e543d · 08e543d
1 parent 2bf7a5d
commit 08e543d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/AnkiDroid/src/main/AndroidManifest.xml b/AnkiDroid/src/main/AndroidManifest.xml
@@ -230,13 +230,13 @@
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
                 <category android:name="android.intent.category.DEFAULT" />
+                <action android:name="android.intent.action.SEND"/>
                 <data android:mimeType="application/apkg"/>
                 <data android:mimeType="application/colpkg"/>
                 <data android:mimeType="application/vnd.anki"/>
                 <data android:mimeType="application/x-apkg"/>
                 <data android:mimeType="application/x-colpkg"/>
                 <data android:mimeType="application/octet-stream"/>
-                <data android:mimeType="application/zip"/>
                 <data android:mimeType="text/tab-separated-values"/>
                 <data android:mimeType="text/comma-separated-values"/>
             </intent-filter>

diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/IntentHandlerTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/IntentHandlerTest.kt
@@ -94,17 +94,19 @@ class IntentHandlerTest {
 
     @Test
     fun textImportIntentReturnsTextImport() {
-        // TSV import
-        var intent = Intent(Intent.ACTION_VIEW)
-        intent.setDataAndType(Uri.parse("content://valid"), "text/tab-separated-values")
-        var expected = getLaunchType(intent)
-        assertThat(expected, equalTo(LaunchType.TEXT_IMPORT))
+        testIntentType("content://valid", "text/tab-separated-values", LaunchType.TEXT_IMPORT)
+        testIntentType("content://valid", "text/comma-separated-values", LaunchType.TEXT_IMPORT)
 
-        // CSV import
-        intent = Intent(Intent.ACTION_VIEW)
-        intent.setDataAndType(Uri.parse("content://valid"), "text/comma-separated-values")
-        expected = getLaunchType(intent)
-        assertThat(expected, equalTo(LaunchType.TEXT_IMPORT))
+        // Test for ACTION_SEND
+        testIntentType("content://valid", "text/tab-separated-values", LaunchType.TEXT_IMPORT, Intent.ACTION_SEND)
+        testIntentType("content://valid", "text/comma-separated-values", LaunchType.TEXT_IMPORT, Intent.ACTION_SEND)
+    }
+
+    private fun testIntentType(data: String, type: String, expected: LaunchType, action: String = Intent.ACTION_VIEW) {
+        val intent = Intent(action)
+        intent.setDataAndType(Uri.parse(data), type)
+        val actual = getLaunchType(intent)
+        assertThat(actual, equalTo(expected))
     }
 
     @Test