Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vector flags for all available countries #534

Closed
flipflop97 opened this issue Apr 16, 2022 · 5 comments
Closed

Use vector flags for all available countries #534

flipflop97 opened this issue Apr 16, 2022 · 5 comments
Labels
chore Documentation, licenses, repository structure, dependency upgrades, etc.
Milestone

Comments

@flipflop97
Copy link
Contributor

While this deck uses mostly svg images for flags of countries, some flags use raster images while they are freely available as svg like Croatia. Is there any reasoning behind this? Otherwise, it would be nice to replace the raster images with vector images.

@axelboc
Copy link
Collaborator

axelboc commented Apr 16, 2022

It's a matter of file size. The cut off is currently at 50 kB for SVGs; anything greater is converted to PNG. Given that there are only 18 PNG flags left, that flags weigh 11 times less than maps all up (1 MB vs 11 MB), and that that phones have more storage these days. it might be worth reconsidering whether this limit still makes sense.

@axelboc axelboc added the chore Documentation, licenses, repository structure, dependency upgrades, etc. label Jun 25, 2022
@KentGrigo
Copy link
Contributor

I've made a PR for this issue here: #577

It doesn't vectorize all the flags as I was uncertain about how to handle some flags due to #111.
I've added further details in a comment to the PR.

@KentGrigo
Copy link
Contributor

Note: As @axelboc has already mentioned, this will increase the size of the files above the 50 kB.
But in case you want to abandon this constraint, #577 is a partial solution.

@aplaice
Copy link
Collaborator

aplaice commented Oct 23, 2022

The following flags still need to be vectorized:

  • Belize
  • Bolivia
  • Costa Rica
  • El Salvador
  • Peru
  • Venezuela

These flags were not vectorized because they also needed to be blurred:

  • Bolivia
  • El Salvador

and these flags because they didn't correspond to the first flag on Wikipedia,

  • Belize
  • Bolivia
  • Costa Rica
  • Peru
  • Venezuela

(Copied from @KentGrigo's summary. (Thanks!))

@KentGrigo
Copy link
Contributor

Sorry for going AWOL. A lot of personal things came up.
I've now vectorized the rest of the flags, except the blurred versions, which are still rasterized.
PR is here: #587

@axelboc axelboc added this to the v5.2 milestone Jan 15, 2023
@axelboc axelboc closed this as completed Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Documentation, licenses, repository structure, dependency upgrades, etc.
Development

No branches or pull requests

4 participants