Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Develop Homepage - Get In Touch section #214

Closed
3 tasks
mtreacy002 opened this issue Mar 28, 2021 · 22 comments · Fixed by #229
Closed
3 tasks

UI: Develop Homepage - Get In Touch section #214

mtreacy002 opened this issue Mar 28, 2021 · 22 comments · Fixed by #229
Assignees
Labels
Category: User Interface Improvements or additions to design. Open Source Hack Type: Enhancement New feature or request.

Comments

@mtreacy002
Copy link
Member

Description

As a maintainer,
I need to see BIT pages redesigned,
so that they meet the AnitaB Org guidelines.

Mocks

Approved design idea for Get in touch form section (Designer Rahul Mohata)
Screen Shot 2021-03-28 at 5 23 59 pm

Acceptance Criteria

Update [Required]

  • Implement the design above in the section it is intended (Get In Touch section of the homepage).

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1 hour

Additional Information

Link to Figma file

@mtreacy002 mtreacy002 added Category: User Interface Improvements or additions to design. Open Source Hack Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Enhancement New feature or request. labels Mar 28, 2021
@mtreacy002
Copy link
Member Author

@Rahulm2310 , would you like to work on this issue? You can remove the OSH label if you'd like to work on it as you are the OSH mentor 😁. But this is afterall your design idea, so you have the right to claim it first 😉. If you are happy for other contributors to work on this, feel free to relabel it as Available and keep the 'Open Source Hack` label on.

@Rahulm2310
Copy link
Contributor

@mtreacy002 I would be more than happy to give other contributors a chance 😊

@Rahulm2310 Rahulm2310 added Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. labels Mar 28, 2021
@naveen8801
Copy link
Contributor

hi @mtreacy002 @Rahulm2310 , I'd like to work on it , please assign it to me :-)

@Amulya-coder
Copy link
Member

Yours @naveen8801 Happy coding 🎉

@Amulya-coder Amulya-coder removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 31, 2021
@Rahulm2310
Copy link
Contributor

@naveen8801 Please complete the compulsary task #218 before working on anything else. Unassigning you for now. Please re-claim it once the compulsory task is done. 🙂

@Rahulm2310 Rahulm2310 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 31, 2021
@battuAshita
Copy link
Contributor

Hi @mtreacy002. I would like to work on this issue. Can it be assigned to me?

@Rahulm2310
Copy link
Contributor

@battuAshita Thanks for showing interest. Please complete the compulsary task #218 before claiming any other issue. Thanks 😊

@battuAshita
Copy link
Contributor

Yes. Will complete and get back:) Thank you

@shades-7
Copy link
Contributor

shades-7 commented Apr 2, 2021

can I work on this?

@Rahulm2310
Copy link
Contributor

Yours @shades-7. Happy Coding 😊

@Rahulm2310 Rahulm2310 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 2, 2021
@Amulya-coder
Copy link
Member

@shades-7 you're already assigned to #203 please wait for the reviewers to review it moreover contributors will assign up to one issue atm when it's getting ready to merge then you can reclaim this issue again 😉.

@Amulya-coder Amulya-coder added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 2, 2021
@devkapilbansal
Copy link
Member

@Amulya-coder AFAIK as long as PR is not marked as changes requested new issue can be assigned to the contributor.

Also, @shades-7 you can contribute by reviewing others PR too. Reviewing each other PRs will ease the work of maintainers and for sure will increase your expertise towards particular domain

@shades-7
Copy link
Contributor

shades-7 commented Apr 3, 2021

hello, where should i submit my prototype for this?

@Rahulm2310
Copy link
Contributor

@shades-7 this issue is for implementing the UI and not designing. The designs are already approved. You need to develop this component and add it to the home page. 😊

@shades-7
Copy link
Contributor

shades-7 commented Apr 3, 2021

@shades-7 this issue is for implementing the UI and not designing. The designs are already approved. You need to develop this component and add it to the home page. 😊

Do I have to make it responsive too? If yes, what's the design for mob version?

@Rahulm2310
Copy link
Contributor

@shades-7 Simply try stacking the heading and the form on one another like -
Get in Touch
Subtitle
Form

@Rahulm2310 Rahulm2310 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 4, 2021
@Rahulm2310
Copy link
Contributor

@mtreacy002 Title of the design issues sounds misleading (sounds more like design than development). Can you please update it to something more specific like UI: Develop Homepage - Get In Touch section ?

@mtreacy002 mtreacy002 changed the title UI: Redesign Homepage - Get In Touch section UI: Develop Homepage - Get In Touch section Apr 4, 2021
@shades-7
Copy link
Contributor

shades-7 commented Apr 7, 2021

should I make this section in the home component and can I get Figma link too?

@Rahulm2310
Copy link
Contributor

@shades-7 Please create a seperate component for it and then add it to the homepage. Link to the figma file is available in the issue description.

@shades-7
Copy link
Contributor

shades-7 commented Apr 12, 2021

@Rahulm2310 can't find the font "meta pro" what to do?
for how many dimensions I have to write a media query?

@shades-7
Copy link
Contributor

Screenshot from 2021-04-12 17-19-21
This is how it looks right now with the font

@mtreacy002
Copy link
Member Author

@Rahulm2310 can't find the font "meta pro" what to do?

@shades-7 , the file to download the font Meta Pro was referred to in the zulip discussion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: User Interface Improvements or additions to design. Open Source Hack Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants