New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Known issues and Re-implementing in Python #5

Open

4 of 7 tasks

animerl opened this issue Nov 5, 2022 · 1 comment

Assignees

Labels

bug enhancement good first issue

Owner

animerl commented Nov 5, 2022 •

edited

Loading

Rewrite the code in Python
- Standard bracket conversion
- Escape literal round brackets (parentheses) and replace _ to " "(space)
  - ex: XXX_(YYY)→XXX \(YYY\)
- Add quality tag(s)
- (Issue) Detects and warns of bracket inconsistencies
  - Implement function
- Add API endpoints (Possible to add an API endpoint in stable-diffusion-webui? #4)

animerl added bug enhancement good first issue labels

animerl assigned animerl, krisfail and aliencaocao

Collaborator

aliencaocao commented Dec 9, 2022 •

edited

Loading

How do we handle unclosed brackets? For example {{hello}
~~Currently I am planning to make it become {(hello:1.05) so it just treats all unclosed brackets as a literal string.~~ But I am not sure if this is how NAI actually does it.

EDIT: tried with current implementation, it simply removes the unclosed brackets. Will follow this behaviour in Python rewrite.

aliencaocao linked a pull request

that will close this issue

Python rewrite #8

Draft

aliencaocao removed a link to a pull request

Python rewrite #8

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment