Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pipe package #492

Merged
merged 3 commits into from
Jan 2, 2023
Merged

added pipe package #492

merged 3 commits into from
Jan 2, 2023

Conversation

TClark1011
Copy link
Contributor

@TClark1011 TClark1011 commented Aug 22, 2022

NOTE: I did not add the rollup config because I wasn't sure how I should configure it

NOTE: I did not rollup config because I wasn't sure how I should configure it
Copy link
Owner

@angus-c angus-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a few small issues. Also did you run yarn generate-readmes? I would have expected updates to global README.ms too.

@@ -1599,5 +1599,16 @@
"const squareFn = (number) => number * number;",
"deepMapValues({ a: 1, b: { c: 2, d: { e: 3 } } }, squareFn); // => { a: 1, b: { c: 4, d: { e: 9 } } }"
]
},
"just-flow": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename just-flow to just-pipe

t.end();
});

test('Throws if only give 0 or 1 parameters', function(t) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the fail case where second param is a non-function

function double(b) {
return b * 2;
}
t.equal(pipe(3, addOne, double), 8);
Copy link
Owner

@angus-c angus-c Aug 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be good to test with args 2 and 3 swapped

@TClark1011
Copy link
Contributor Author

@angus-c requested changes have been made, sorry for the delay

@angus-c
Copy link
Owner

angus-c commented Nov 19, 2022

Sorry for the even bigger delay from me! Thanks for making the changes. I still don't see a global README for some reason. I'm going to merge now anyway and try running the script myself—and the one for .mjs generation. Might not get to doing those updates it immediately, so it won't be published right away.
Thanks again!

@angus-c angus-c merged commit ca899a9 into angus-c:master Jan 2, 2023
@angus-c
Copy link
Owner

angus-c commented Jan 2, 2023

Ok my bad it was there but not in alpha order so I didn't see in global README
Re-ordered #529

@angus-c
Copy link
Owner

angus-c commented Jan 2, 2023

Published as [email protected]

@angus-c
Copy link
Owner

angus-c commented Jan 2, 2023

And now available in REPL
https://anguscroll.com/just/just-pipe

@angus-c angus-c mentioned this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants