-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pipe
package
#492
added pipe
package
#492
Conversation
NOTE: I did not rollup config because I wasn't sure how I should configure it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just a few small issues. Also did you run yarn generate-readmes
? I would have expected updates to global README.ms too.
md-variables.json
Outdated
@@ -1599,5 +1599,16 @@ | |||
"const squareFn = (number) => number * number;", | |||
"deepMapValues({ a: 1, b: { c: 2, d: { e: 3 } } }, squareFn); // => { a: 1, b: { c: 4, d: { e: 9 } } }" | |||
] | |||
}, | |||
"just-flow": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename just-flow
to just-pipe
test/function-pipe/index.js
Outdated
t.end(); | ||
}); | ||
|
||
test('Throws if only give 0 or 1 parameters', function(t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the fail case where second param is a non-function
function double(b) { | ||
return b * 2; | ||
} | ||
t.equal(pipe(3, addOne, double), 8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also be good to test with args 2 and 3 swapped
@angus-c requested changes have been made, sorry for the delay |
Sorry for the even bigger delay from me! Thanks for making the changes. I still don't see a global README for some reason. I'm going to merge now anyway and try running the script myself—and the one for |
Ok my bad it was there but not in alpha order so I didn't see in global README |
Published as [email protected] |
And now available in REPL |
NOTE: I did not add the rollup config because I wasn't sure how I should configure it