Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(all): migrate to package:web #75

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

refactor(all): migrate to package:web #75

wants to merge 6 commits into from

Conversation

ahmednfwela
Copy link

No description provided.

@ahmednfwela ahmednfwela mentioned this pull request Jun 14, 2024
Closed
@GZGavinZhao GZGavinZhao added the enhancement New feature or request label Jun 14, 2024
@GZGavinZhao
Copy link

Current blockers, working on them one by one:

  • JSTestability needs to be migrated to staticInterop and extension types. (Mostly done, tests need to be updated)
  • Don't use tear-offs for extension methods. Not difficult to do, just annoying because we use them all over the place in tests for convenience.
  • Functions that are wrapped with toJS need to have more explicit types that follow the interop rules. This is actually a good thing because we'll then have stricter type guarantees.
  • It seems like ElementRef needs to be eliminated. (this may warrant its own issue?)

ykmnkmi
ykmnkmi reviewed Jun 17, 2024
View reviewed changes
ngdart/lib/src/runtime/dom_events.dart
@@ -88,7 +91,7 @@ class _KeyEventsHandler {

element.addEventListener(
parsed.domEventName,
(event) {
(Event event) {
if (event is KeyboardEvent && parsed.matches(event)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be event.isA<KeyboardEvent>().

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isA() requires to bump SDK to 3.4.0

@GZGavinZhao GZGavinZhao changed the title feat: migrate to package:web refactor(all): migrate to package:web Jun 17, 2024
@GZGavinZhao GZGavinZhao mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykmnkmi ykmnkmi ykmnkmi left review comments

@genesistms genesistms genesistms left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmednfwela @GZGavinZhao @genesistms @ykmnkmi