This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: resolve errors with closure #722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't patch all "on" properties if a list of properties is being passed in. Otherwise various global variables in window get clobbered.
|
Could you get this green? |
| if (properties) { | ||
| for (let i = 0; i < properties.length; i++) { | ||
| patchProperty(obj, 'on' + properties[i]); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
@vikerman , I think we should merge the properties array and prop in obj and then remove duplicate ones, because if we use if/else here, some properties may not be patched.
so I think the logic should be.
if (properties) {
for (let i = 0; i < properties.length; i++) {
const onProp = 'on' + properties[i];
if (onProperties.filter(op => op === onProp)).length > 0) {
continue;
}
patchProperty(obj, onProp);
}
}
mhevery
pushed a commit
that referenced
this pull request
Apr 21, 2017
Also don't patch all "on" properties if a list of properties is being passed in. Otherwise various global variables in window get clobbered. Closes #722
mhevery
pushed a commit
that referenced
this pull request
Apr 21, 2017
Also don't patch all "on" properties if a list of properties is being passed in. Otherwise various global variables in window get clobbered. Closes #722
mhevery
pushed a commit
that referenced
this pull request
Apr 21, 2017
Also don't patch all "on" properties if a list of properties is being passed in. Otherwise various global variables in window get clobbered. Closes #722
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't patch all "on" properties if a list of properties is being
passed in. Otherwise various global variables in window get clobbered.