-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Tsickle to use TypeScript v2.1 transforms #285
Comments
/cc @chuckjaz |
Did they expose the transforms API to external users? Last I heard this was an internal-only API. |
My understanding from discussing with @chuckjaz is that it will be available in v2.1. |
@chuckjaz do you have a pointer to docs on it?
|
I just checked the TS source and the transforms stuff is still marked @internal. |
Depends on #295 first. |
Last news on this is that they anticipate exposing transforms in the next few weeks, but it'll be in a later TS release. We can wait. |
Seems like 1 more thing left for this transformer API. See this comment |
We need to migrate tsickle to TS 2.3 for this new API. Historically that's taken a small amount of work to adjust to API changes but I haven't looked yet at how hard it will be. |
With the TS upgrade down (#471) I guess this is unblocked now. |
Fixed. |
Currently Tsickle does not use TypeScript v2.1 transforms API. The consequence is that
ngc
has to parse the type information twice. Once for the original source code, and then again whentsickle
pulls annotations into static fields. The consequence of this is slower runtime performance.The text was updated successfully, but these errors were encountered: