Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Tsickle to use TypeScript v2.1 transforms #285

Closed
mhevery opened this issue Nov 29, 2016 · 12 comments
Closed

Rewrite Tsickle to use TypeScript v2.1 transforms #285

mhevery opened this issue Nov 29, 2016 · 12 comments

Comments

@mhevery
Copy link

mhevery commented Nov 29, 2016

Currently Tsickle does not use TypeScript v2.1 transforms API. The consequence is that ngc has to parse the type information twice. Once for the original source code, and then again when tsickle pulls annotations into static fields. The consequence of this is slower runtime performance.

@mhevery
Copy link
Author

mhevery commented Nov 29, 2016

/cc @chuckjaz

@evmar
Copy link
Contributor

evmar commented Nov 29, 2016

Did they expose the transforms API to external users? Last I heard this was an internal-only API.

@mhevery
Copy link
Author

mhevery commented Nov 29, 2016

My understanding from discussing with @chuckjaz is that it will be available in v2.1.

@mprobst
Copy link
Contributor

mprobst commented Nov 29, 2016 via email

@evmar
Copy link
Contributor

evmar commented Dec 2, 2016

@evmar
Copy link
Contributor

evmar commented Dec 6, 2016

Depends on #295 first.

@evmar
Copy link
Contributor

evmar commented Jan 11, 2017

Last news on this is that they anticipate exposing transforms in the next few weeks, but it'll be in a later TS release. We can wait.

@shlomiassaf
Copy link

Seems like 1 more thing left for this transformer API.

See this comment

@KiaraGrouwstra
Copy link

As I understand it their alternative PR for this has been merged by now. Hope that could unblock this for those AoT lambdas! @chuckjaz @mhevery

@evmar
Copy link
Contributor

evmar commented Apr 12, 2017

We need to migrate tsickle to TS 2.3 for this new API. Historically that's taken a small amount of work to adjust to API changes but I haven't looked yet at how hard it will be.

@KiaraGrouwstra
Copy link

With the TS upgrade down (#471) I guess this is unblocked now.

@evmar
Copy link
Contributor

evmar commented Aug 20, 2019

Fixed.

@evmar evmar closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants