You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
I have not experimented with this but I was looking through the protractor code base and I see what looks like a bug at protractor.js Line 841 and following. It appears entirely possible to add two mock modules with the same name, have them both applied to the browser and then need to call removeMockModule twice with that name to remove them both. Am I reading this right? Is this correct behavior?
The text was updated successfully, but these errors were encountered:
Looking at this more, there is also a bug in removeMockModule such that if you pass in a module name that does not exist, it does not validate validate the argument. The result being that it will incorrectly remove the most recently added module.
So at this point I have written unit tests that confirm both behaviors malfunction as I suspected and have submitted a pull request containing the confirming tests and associated fixes. Someone may want to review my unit tests. I think there may be a better approach.
I have not experimented with this but I was looking through the protractor code base and I see what looks like a bug at protractor.js Line 841 and following. It appears entirely possible to add two mock modules with the same name, have them both applied to the browser and then need to call removeMockModule twice with that name to remove them both. Am I reading this right? Is this correct behavior?
The text was updated successfully, but these errors were encountered: