Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

by.exactRepeater() not working on 2.2.0 #2453

Closed
williamboman opened this issue Aug 26, 2015 · 5 comments
Closed

by.exactRepeater() not working on 2.2.0 #2453

williamboman opened this issue Aug 26, 2015 · 5 comments

Comments

@williamboman
Copy link

by.exactRepeater is not finding any elements on [email protected]. It works perfectly fine on [email protected].

@williamboman
Copy link
Author

This is due to #2335, also mentioned here 🙈. I had included = in my repeat descriptors. Editing those fixes this. I'll leave this open for future travelers.

by.exactRepeater('foo in bar = (baz');
// to
by.exactRepeater('foo in bar')

@NickTomlin
Copy link
Contributor

@williamboman could you actually close the issue? That will make it easier for the maintainers to sift through issues; the solution will still be here for anyone searching for the problem.

@williamboman
Copy link
Author

@NickTomlin I think it's worth having this issue open for a few more days to avoid any duplicates. Feel free to add any labels or close this issue (I'll otherwise close it soon).

This change should've kept backwards-compatibility IMO (due to the versioning), or at least included a deprecation notice for previously semantically valid, albeit syntactically invalid, descriptors.

assuming protractor follows semver

@hankduan
Copy link
Contributor

@williamboman Sorry about the breaking change. We did not increase the major version since this was considered a fix to a previously bug. But I agree, we should be more careful of these types of pushes in the future.

Let's keep this open for a week, and close it then (it'll still be searchable)

@williamboman
Copy link
Author

One GitHub-week later...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants