Add NgModules for material #950
Conversation
googlebot
added
the
cla: yes
| @@ -12,7 +12,8 @@ export { | |||
| export { | |||
There was a problem hiding this comment.
Export a core module from here, or export all sub-modules through this file.
There was a problem hiding this comment.
Exported individual modules and added an MdCoreModule
|
Globally the feel is good. Please address my previous comment. |
| RtlModule, | ||
| ]; | ||
|
|
||
| @NgModule(({ |
| template: ` | ||
| <md-button-toggle>Yes</md-button-toggle> | ||
| ` | ||
| }) | ||
| class StandaloneButtonToggle { } | ||
|
|
||
| const TEST_COMPONENTS = [ |
There was a problem hiding this comment.
These are only used once, please inline them.
| @@ -122,7 +124,7 @@ function detectChangesForDialogOpen(fixture: ComponentFixture<ComponentWithChild | |||
| // Two rounds of change detection are necessary: one to *create* the dialog container, and | |||
| // another to cause the lifecycle events of the container to run and load the dialog content. | |||
| fixture.detectChanges(); | |||
| setTimeout(() => fixture.detectChanges(), 50); | |||
| setTimeout(() => fixture.detectChanges(), 150); | |||
There was a problem hiding this comment.
Nit; is this necessary and can we make it async? 150 is really long for a unittest.
There was a problem hiding this comment.
Leftover from debugging, reverted.
(and will likely go away when the zone fix is in)
|
Removed all |
|
@hansl all comments should be resolved |
|
LGTM. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @hansl @kara
This PR includes:
directives: [...]MaterialModule)injectis beforefakeAsync(and probably async), tests do not use the expected zone angular#10503@experimentalyesterday)Providersyntax