-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(progress-circle): remove performance.now to support non browser envs #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Nov 6, 2024
- fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes angular#857 Co-authored-by: Michael Prentice <[email protected]>
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 12, 2024
- fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes angular#857 Co-authored-by: Michael Prentice <[email protected]>
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 16, 2024
- fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes angular#857 Co-authored-by: Michael Prentice <[email protected]>
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 18, 2024
- fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes angular#857 Co-authored-by: Michael Prentice <[email protected]>
josephperrott
pushed a commit
that referenced
this pull request
Dec 18, 2024
- fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes #857 Co-authored-by: Michael Prentice <[email protected]>
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 18, 2024
- fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes angular#857 Co-authored-by: Michael Prentice <[email protected]>
kseamon
pushed a commit
to kseamon/material2
that referenced
this pull request
Dec 18, 2024
- fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes angular#857 Co-authored-by: Michael Prentice <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the reference to the performance global, as it doesn't work in environments without a window.
r: @jelbourn