feat(tooltip): initial tooltip implementation #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
in progress
jelbourn
changed the title
| @@ -16,7 +16,7 @@ import {Observable} from 'rxjs/Observable'; | |||
|
|
|||
| describe('MdTabGroup', () => { | |||
| let builder: TestComponentBuilder; | |||
| let fixture: ComponentFixture<SimpleTabsTestApp>; | |||
| let fixture: ComponentFixture<any>; | |||
There was a problem hiding this comment.
I have a different fix for this in #843
7 tasks
|
@robertmesserle needs rebase (plus one comment on scss vars) |
|
Rebased and addressed SCSS comment |
|
@jelbourn And now, it's actually green. Let me know if it's good to merge. |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jelbourn @kara @iveysaur @hansl
E2E tests coming in follow-up PR.