fix(progress-circle): render determinate and indeterminate across all supported browsers #375
Conversation
googlebot
added
the
cla: yes
| @@ -3,15 +3,12 @@ | |||
| @import "default-theme"; | |||
|
|
|||
| /* Animation Durations */ | |||
| $md-progress-circle-duration : 5.25s !default; | |||
| $md-progress-circle-value-change-duration : $md-progress-circle-duration * 0.25 !default; | |||
| $md-progress-circle-duration : 5332ms !default; | |||
There was a problem hiding this comment.
Can you add any info on where this value comes from?
|
@joeyperson Now needs rebasing on my mega change #384. Let me know if you need any help with that (next week, of course). |
|
Rebased. |
| // total circumference. | ||
| private _renderCircle(animateFrom: number, animateTo: number, | ||
| ease: (currentTime: number, startValue: number, | ||
| changeInValue: number, duration: number) => number, |
There was a problem hiding this comment.
You should be able to alias this type so that it's a little more readable here:
type EasingFn = (currentTime: number, startValue: number, changeInValue: number, duration: number) => number(see the Dir directive for an example)
| /** | ||
| * Determines the path value to define the arc. | ||
| */ | ||
| function getSvgArc(current: number, rotation: number) { |
There was a problem hiding this comment.
Need more explanation about what the function is returning.
|
LGTM aside from a couple minor style nits. |
* The cdk-table guide became the overview document for the cdk table component. Therefore it's no longer a guide.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
For #295