-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): fix ink not showing on chrome 57 #3041
fix(tabs): fix ink not showing on chrome 57 #3041
Conversation
4e65f78
to
d0e42ca
Compare
|
||
/** Checks if the active link has been changed and, if so, will update the ink bar. */ | ||
ngAfterContentChecked(): void { | ||
if (this._activeLinkChanged) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we can't do this in the updateActiveLink method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial set for active
is performed while the component is setting up and before the content is ready, so the ink bar doesn't know what to align to. Subsequent calls would be fine but we're seeing an issue with the first load of the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The ink bar was positioned absolutely in a display flex element, which no longer plays nice in Chome (beta, v 57). Moved the ink bar out of the display flex element. Also fixed issue for the nav bar, which did not always show the ink bar on first render.