Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply font-family to text components #2821

Merged
merged 1 commit into from
Feb 1, 2017

Conversation

devversion
Copy link
Member

  • Applies the font-family to all components that use content projection and have a label or a text displayed.
  • Switches the hard-coded font-family in the simple-snack-bar to the global variable.

Notes:

  • All families have been applied to the host elements (to simplify font overwriting)
  • The dialog font family has been skipped here. Not sure whether we want that for the users instantiated component (I'd only say md-dialog-content etc. directives)

References #2750

* Applies the `font-family` to all components that use content projection and have a label or a text displayed.
* Switches the hard-coded font-family in the `simple-snack-bar` to the global variable.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 26, 2017
@jelbourn
Copy link
Member

LGTM, though we may revisit once we work on a more comprehensive typography approach

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 27, 2017
@kara kara merged commit d11673a into angular:master Feb 1, 2017
@devversion devversion deleted the fix/font-family-components branch February 1, 2017 05:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants