fix(slider): fire change event on value change via keyboard. #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also disable animation for keyboard changes because they look crazy.
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 27, 2017
| /** Increments the slider by the given number of steps (negative number decrements). */ | ||
| private _increment(numSteps: number) { | ||
| this.value = this._clamp(this.value + this.step * numSteps, this.min, this.max); | ||
| this._emitInputEvent(); | ||
| this._emitValueIfChanged(); |
There was a problem hiding this comment.
Can we add either a unit or e2e test for this?
|
tests added |
kara
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also disable animation for keyboard changes because they look crazy.
fixes #2764