Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(overlay): cdk-connected-overlay with size dont remove cdk-connected-pane on close #2739

Closed
Socolin opened this issue Jan 21, 2017 · 1 comment · Fixed by #2747
Closed

bug(overlay): cdk-connected-overlay with size dont remove cdk-connected-pane on close #2739

Socolin opened this issue Jan 21, 2017 · 1 comment · Fixed by #2747
Assignees
@devversion

Comments

@Socolin
Copy link

Socolin commented Jan 21, 2017

What is the expected behavior?

cdk-overlay-pane should disapear on close

What is the current behavior?

cdk-overlay-pane stay open and prevent from clicking on element under it

What are the steps to reproduce?

http://plnkr.co/edit/pH6rE07ldEq5EgZqWzkq?p=preview
@devversion devversion self-assigned this Jan 21, 2017
devversion added a commit to devversion/material2 that referenced this issue Jan 21, 2017
@devversion
fix(overlay): hide pane element if detached
be56a67 
* Currently the overlay element is still visible if the overlay has been detached.
  This is problematic if the overlay pane element has an `height | wídth` set from the state, because now the overlay element may block clicks on the page and overlap the actual content.

* The issue isn't noticable for the `select` and other overlay components, because those don't specify a `height | width` in their state.
   Nevertheless the pane elements are still visible, but just have no height and width set.

Fixes angular#2739
@devversion devversion mentioned this issue Jan 21, 2017
Merged
@kara kara closed this as completed in #2747 Feb 2, 2017
kara pushed a commit that referenced this issue Feb 2, 2017
@devversion @kara
fix(overlay): disable pointer events if overlay is detached (#2747)
453fa7f 
Fixes #2739
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(overlay): disable pointer events if overlay is detached devversion/material2
2 participants
@Socolin @devversion