Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenav disappears when escape is pressed #2462

Closed
andrewseguin opened this issue Dec 29, 2016 · 1 comment · Fixed by #2501
Closed

Sidenav disappears when escape is pressed #2462

andrewseguin opened this issue Dec 29, 2016 · 1 comment · Fixed by #2501
Assignees
@devversion

Comments

@andrewseguin
Copy link
Contributor

andrewseguin commented Dec 29, 2016 •
edited
Loading

This is not always intended, see https://material.angular.io/components for example. Click on the sidenav and press escape to see it disappear. Cannot get the sidenav back.
devversion added a commit to devversion/material2 that referenced this issue Jan 2, 2017
@devversion
feat(sidenav): add disableClose option
8cd6ec5 
* Adds an attribute to the `md-sidenav` component, which allows developers to disable the closing behavior (e.g escape closing)
  Backdrop stays separate because you can disable it by using the `mode` attribute.

Closes angular#2462
@devversion devversion mentioned this issue Jan 2, 2017
Merged
@devversion devversion self-assigned this Jan 2, 2017
tinayuangao pushed a commit that referenced this issue Jan 13, 2017
@devversion @tinayuangao
feat(sidenav): add disableClose option (#2501)
52ade97 
* feat(sidenav): add disableClose option

* Adds an attribute to the `md-sidenav` component, which allows developers to disable the closing behavior (e.g escape closing)
  Backdrop stays separate because you can disable it by using the `mode` attribute.

Closes #2462

* Address comments
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sidenav): add disableClose option devversion/material2
2 participants
@devversion @andrewseguin