Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-bar): unable to apply visibility in indeterminate mode and reduce CSS #2417

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 27, 2016

  • Fixes being unable to apply visibility: hidden to progress bars in indeterminate or buffer mode.
  • Slightly reduces the amount of CSS used for the progress-bar component.
  • Removes an unused import.

Fixes #2413.

@crisbeto crisbeto requested a review from jelbourn December 27, 2016 11:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 27, 2016
…nd reduce CSS

* Fixes being unable to apply `visibility: hidden` to progress bars in `indeterminate` or `buffer` mode.
* Slightly reduces the amount of CSS used for the `progress-bar` component.
* Removes an unused import.

Fixes angular#2413.
@crisbeto crisbeto force-pushed the 2413/progress-bar-visibility branch from 7bf81ac to 9f1f01f Compare December 27, 2016 11:32
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 28, 2016
@kara kara merged commit eb96b0c into angular:master Jan 4, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style.Visibility is not working for MdProgressbar with mode="indeterminate".
4 participants