Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add the ability to invert the header #2391

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

crisbeto
Copy link
Member

Adds the ability to set the tab header position to the bottom. This inverts the tabs and the ink bar.

Fixes #2387.

Adds the ability to set the tab header position to the bottom. This inverts the tabs and the ink bar.

Fixes angular#2387.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 24, 2016
@jelbourn jelbourn requested review from andrewseguin and removed request for jelbourn December 28, 2016 03:39
@JT-Bruch
Copy link

Any progress on this? Would love to see it in.

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like it works well with dynamic height and pagination. Thanks for adding this

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 17, 2017
@mmalerba mmalerba merged commit a494c92 into angular:master Jan 18, 2017
kara pushed a commit to kara/material2 that referenced this pull request Jan 20, 2017
Adds the ability to set the tab header position to the bottom. This inverts the tabs and the ink bar.

Fixes angular#2387.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tabs] Header should have option to be aligned at bottom
5 participants