feat: make hammerjs optional #2280
Conversation
googlebot
added
the
cla: yes
| constructor() { | ||
| super(); | ||
|
|
||
| if (!this._hammer) { |
There was a problem hiding this comment.
Can you import isDevMode from @angular/core and then only log this warning if isDevMode() is true?
| @@ -4,16 +4,25 @@ import {HammerGestureConfig} from '@angular/platform-browser'; | |||
| /* Adjusts configuration of our gesture library, Hammer. */ | |||
| @Injectable() | |||
| export class MdGestureConfig extends HammerGestureConfig { | |||
| private _hammer = typeof window !== 'undefined' ? (window as any).Hammer : null; | |||
There was a problem hiding this comment.
Rather than making it any, could you add a GestureManager interface that just copies the members of HammerManager that we're using?
There was a problem hiding this comment.
I went with any here and a bit below, because it throws a TS compile error if HammerJS is missing.
There was a problem hiding this comment.
Right- instead of dropping all the way down to any, though, we can introduce out own interface and say (window as any).Hammer as GestureManager
There was a problem hiding this comment.
Makes sense, I'll look into the API.
crisbeto
force-pushed
the
optional-hammer
branch
from
5dffefb
to
adba735
Compare
Makes HammerJS and logs a warning if it's missing, instead of crashing the app.
crisbeto
force-pushed
the
optional-hammer
branch
from
adba735
to
0c7b8fb
Compare
|
Updated @jelbourn. I've replaced the HammerJS interfaces with our own stripped-down alternatives. |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Makes HammerJS and logs a warning if it's missing, instead of crashing the app.