Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gestures): remove drag event from config #1744

Merged
merged 1 commit into from
Nov 8, 2016
Merged

fix(gestures): remove drag event from config #1744

merged 1 commit into from
Nov 8, 2016

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 5, 2016

Removes the drag event from the gesture config.

Fixes #1025.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 5, 2016
@crisbeto
Copy link
Member Author

crisbeto commented Nov 5, 2016

@jelbourn I'm not too familiar with the gesture setup, are we supposed to remove the drag event from here as well?

@devversion
Copy link
Member

devversion commented Nov 5, 2016 •
edited
Loading

@crisbeto I think it depends on what we are trying to archive.

Recently in b09465c, the dragstart and dragend have been removed, which means that the HammerJS drag event is kind of unusable right now.

We still have the slide event which is used by all components, which support panning gestures right now.

In my opinion, we should remove the drag recognizer and associated events here, and just use the slide event (it has a lower threshold -> feels better)

@crisbeto
Copy link
Member Author

crisbeto commented Nov 5, 2016

Thanks @devversion,, removed.

devversion
devversion reviewed Nov 5, 2016
View reviewed changes
src/lib/core/gestures/MdGestureConfig.ts
@@ -7,7 +7,6 @@ export class MdGestureConfig extends HammerGestureConfig {

/* List of new event names to add to the gesture support list */
events: string[] = [
'drag',
'dragright',
'dragleft',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you forgot to remove the dragright and dragleft here

@crisbeto
fix(gestures): remove drag event from config
04fb5b7 
Removes the `drag` event from the gesture config.

Fixes angular#1025.
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 8, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 8, 2016

LGTM

@jelbourn jelbourn merged commit 4af3cd3 into angular:master Nov 8, 2016
rolandjitsu pushed a commit to rolandjitsu/material2 that referenced this pull request Nov 10, 2016
@crisbeto @rolandjitsu
fix(gestures): remove drag event from config (angular#1744)
2247558 
Removes the `drag` event from the gesture config.

Fixes angular#1025.
@devversion devversion mentioned this pull request Jul 25, 2017
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drag events dataTransfer is undefined in RC5 alpha 7-2 with NgModule imports
4 participants
@crisbeto @devversion @jelbourn @googlebot