feat(tabs): add ripples to the tab group and nav bar links

[andrewseguin]

No description provided.

[kara]

Does the user have to add the ripple themselves if using tab-link?

[andrewseguin]

Yeah, this isn't so ideal. I talked to Jeremy and I might be able to play around a bit more with md-tab-link to get it working as a ripple. I'll send a message when this PR has that incorporated

[kara]

Sure, sounds good. If you haven't already, you might want to check out md-button's ripple. It's also an attr directive on an anchor.

[andrewseguin]

Okay, I made MdTabLink extend the MdRipple so that it automatically applies the ripple effect on the element. What do you guys think of this approach?

[andrewseguin]

Tests are failing due to lacking changes from PR #1684 which fixes ripple pointer events

[andrewseguin]

Tests are passing, able to be reviewed now

[kara]

Conceptually, I find it a bit confusing that the link extends a ripple. Any reason why we wouldn't convert this to a component and use the md-ripple-trigger property?

[andrewseguin]

I agree, it's odd to say that the md tab link extends a ripple. I'd prefer to keep this an attribute directive to preserve the end user's HTML using all native elements (nav, a), e.g.:

<nav md-tab-nav-bar>
  <a md-tab-link>Link</a>
  <a md-tab-link>Link</a>
</nav>

So there are two more alternatives:

1. Add [md-tab-link] selector to the MdRipple
2. Create a new MdTabLinkRipple directive that will only extend MdRipple and match [md-tab-link]

In talking with Jeremy, I think (2) sounds better than MdTabLink extending MdRipple and (1) just sounds more silly than either.

[andrewseguin]

Ripple has been extracted out of the md tab link

[kara]

LGTM

[jelbourn]

@andrewseguin can you rebase?

[andrewseguin]

Conflicts resolved, thanks

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}