Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tabs): simplify api #1645

Merged
merged 1 commit into from
Oct 29, 2016
Merged

feat(tabs): simplify api #1645

merged 1 commit into from
Oct 29, 2016

Conversation

jelbourn
Copy link
Member

R: @andrewseguin

BREAKING CHANGE
This does away completely with the md-tab-content directive and adds an optional label property for <md-tab>.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 28, 2016
andrewseguin
andrewseguin approved these changes Oct 28, 2016
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit ea6c817 into angular:master Oct 29, 2016
@jelbourn jelbourn mentioned this pull request Nov 2, 2016
Closed
@andrewseguin andrewseguin mentioned this pull request Nov 3, 2016
Closed
@benelliott benelliott mentioned this pull request Jan 3, 2017
Closed
@jelbourn jelbourn deleted the tabs-simpler branch September 13, 2017 04:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @andrewseguin @googlebot