feat(connected-overlay): support all overlay config properties #1591
Conversation
googlebot
added
the
cla: yes
| } | ||
|
|
||
| set hasBackdrop(value: any) { | ||
| this._hasBackdrop = value === '' || (!!value && value !== 'false'); |
There was a problem hiding this comment.
Should this be the same logic as here?
https://github.com/jelbourn/material2/blob/a70e3e569d026aaf4c0ad8728d9b6091f8673901/src/lib/core/coersion/boolean-property.ts#L3
There was a problem hiding this comment.
Yeah, I was looking for something shared. But looks like that's not in master?
There was a problem hiding this comment.
Not in master yet; I'd copy the logic and add a TODO
| } | ||
|
|
||
| /** Event emitted when the backdrop is clicked. */ | ||
| @Output() backdropClick = new EventEmitter(); |
There was a problem hiding this comment.
Doesn't this require a generic type?
There was a problem hiding this comment.
Yeah, I think it does. It's not throwing, so maybe it's implicitly typed to EventEmitter<void> when set this way? Regardless I'll type it explicitly just in case.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR passes all the overlay config properties through to the connected overlay directive.
r: @jelbourn