Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): remove tooltip component after it's parent destroyed #1470

Merged
merged 2 commits into from
Nov 1, 2016

Conversation

gucheen
Copy link
Contributor

@gucheen gucheen commented Oct 11, 2016

fix #1111

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 11, 2016
@gucheen
Copy link
Contributor Author

gucheen commented Oct 11, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 11, 2016
@jelbourn
Copy link
Member

@gucheen could you add a unit test for this?

@gucheen gucheen force-pushed the fix-remove-tooltip-element branch 3 times, most recently from 8916964 to 2481964 Compare October 12, 2016 01:39
@gucheen gucheen closed this Oct 12, 2016
@gucheen gucheen reopened this Oct 12, 2016
@gucheen
Copy link
Contributor Author

gucheen commented Oct 12, 2016

Unit test has been added, but there was something wrong with the test scripts. 'gulp' was missing in travis.

@gucheen gucheen closed this Oct 13, 2016
@gucheen gucheen reopened this Oct 13, 2016
@jelbourn
Copy link
Member

@andrewseguin this may be obsolete based on your animation change, thoughts?

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good for me, thanks for adding the test. This is an issue even with animation included.

@jelbourn
Copy link
Member

jelbourn commented Nov 1, 2016

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 1, 2016
@hansl hansl merged commit 92ac392 into angular:master Nov 1, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(md-tooltip): tooltip is not removed when parent is
5 participants