fix(slide-toggle): emit change event after drag end #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@devversion can you rebase this now (to make review easier)? |
devversion
force-pushed
the
fix/slide-toggle-drag-event
branch
from
4ed80d9
to
1e16eb2
Compare
|
Whoops, I thought I had already merged #1268. Now I really merged it. |
devversion
force-pushed
the
fix/slide-toggle-drag-event
branch
from
1e16eb2
to
c83cf67
Compare
* Emits a change event after the drag completed. Fixes angular#1390.
devversion
force-pushed
the
fix/slide-toggle-drag-event
branch
from
c83cf67
to
71d591c
Compare
|
Just rebased now on top of |
|
LGTM aside for that same comment |
jelbourn
reviewed
Oct 6, 2016
| expect(slideThumbContainer.classList).toContain('md-dragging'); | ||
|
|
||
| gestureConfig.emitEventForElement('slide', slideThumbContainer, { | ||
| deltaX: 200 // Use a random number which will be clamped. |
There was a problem hiding this comment.
Same comment on the comment as the other PR
There was a problem hiding this comment.
Oh, I just rebased it, and didn't look at it again. Just made the change :)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1390.
FYI: Rebased on top of #1268 (should be merged before)