Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdSelect :'multiple' is specified as a boolean option, but behaves as flag #1845

Closed
ggranum opened this issue Mar 9, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@ggranum
Copy link

ggranum commented Mar 9, 2015

Technically this could be fixed by updating the docs to indicate that multiple is a flag. However, so far as I know, there is no spiffy flag-attribute shortcut for Angular like there is in Polymer, so leaving it as a flag would be a pain.

I added a note to the relevant commit line. Well, probably the relevant line:
786cb3b#commitcomment-10108925

@rschmukler
Copy link
Contributor

@ggranum this is consistent with how a native select behaves, so I would be in favor of documenting it as a flag as opposed to making it just be a boolean. Example

@ggranum
Copy link
Author

ggranum commented Mar 12, 2015

While I despise flag attributes, I wouldn't argue with maintaining consistency between specs - if it works in Angular 1.x. :~)

My understanding is that Angular had to modify the behavior of disabled (ng-disabled) and selected for similar reasons:
https://docs.angularjs.org/api/ng/directive/ngDisabled
https://docs.angularjs.org/api/ng/directive/ngSelected

My interpretation of the main paragraph of that first link is that, if there were a short, HTML valid way to deal with flag options in Angular 1.4, it would have been used in place of creating the ngDisabled directive.

If you can demonstrate how to create a mdSelect that can toggle between multiple and single select with boolean parameter, great!

best,

@rschmukler rschmukler added the needs: team discussion This issue requires a decision from the team before moving forward. label Mar 23, 2015
@robertmesserle robertmesserle added type: enhancement and removed needs: team discussion This issue requires a decision from the team before moving forward. labels Mar 25, 2015
@angular angular locked as resolved and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants